Bound event queues and removed deprecated relay events for improved robustness #6094
Conversation
There was a problem hiding this comment.
Thanks for the PR!
Bounded Event Queues
Queue Size Limiting:
Event queues in several network behaviours are now bounded to a maximum size (MAX_EVENTS = 1024). When the queue reaches this limit, new events are dropped and a warning is logged
This is not pushed yet, right?
Removal of Deprecated Relay Events
Cleaned Event API:
All deprecated event variants have been removed from the relay protocol’sEventenum inprotocols/relay/src/behaviour.rs. This streamlines the event API and reduces maintenance overhead.Internal Logging for Failures:
Event handling logic has been updated to use internal logging (tracing::warn!) instead of generating deprecated events, ensuring that important failure information is still captured without exposing deprecated API elements.
I know that there is issue #4757 for this and the items have already been deprecated, but tbh I am not sure if we should really remove the error events. There have been some people that spoke up about the usefulness of having these events (e.g. for metrics). And I am generally in favor of exposing more info rather than less to the user.
I don't think there is any downside or maintenance burden in keeping them.
elenaf9
added
kind/stale
need/author-input
Bounded Event Queues
Queue Size Limiting:
Event queues in several network behaviours are now bounded to a maximum size (
MAX_EVENTS = 1024). When the queue reaches this limit, new events are dropped and a warning is logged. This change has been applied to the following modules:protocols/floodsub/src/layer.rsprotocols/ping/src/lib.rsprotocols/perf/src/server/behaviour.rsprotocols/perf/src/client/behaviour.rsOverflow Handling:
If the event queue is full, the system logs a warning message for each dropped event, providing visibility into potential overload situations and aiding in debugging.
Removal of Deprecated Relay Events
Cleaned Event API:
All deprecated event variants have been removed from the relay protocol’s
Eventenum inprotocols/relay/src/behaviour.rs. This streamlines the event API and reduces maintenance overhead.Internal Logging for Failures:
Event handling logic has been updated to use internal logging (
tracing::warn!) instead of generating deprecated events, ensuring that important failure information is still captured without exposing deprecated API elements.